Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing serviceMonitor Template and Port Mismatch in service.yml Template #95

Closed
naqshava opened this issue Jul 27, 2024 · 3 comments
Closed
Assignees

Comments

@naqshava
Copy link

Hi,

I installed the Helm chart and encountered two issues:

1.The chart doesn't include a serviceMonitor template, requiring users to create it manually after installation.
2.In the service.yml template, the targetPort should match the port. Currently, this discrepancy prevents the pod and service from binding correctly when checking the endpoint in Kubernetes.
Here is the relevant section of the service.yml template:

spec:
  type: {{ .Values.service.type }}
  ports:
    - port: {{ .Values.service.port }}
      targetPort: http
      protocol: TCP
      name: http

tnx

@phsmith
Copy link
Owner

phsmith commented Jul 29, 2024

Hi @naqshava, thank you for your report. I will look into these issues as soon as possible.

@phsmith phsmith self-assigned this Jul 29, 2024
phsmith added a commit that referenced this issue Jul 29, 2024
- Added minor doc updates
- Added servicMonitor.yaml template
- Fixed services.yaml targetPort
phsmith added a commit that referenced this issue Jul 29, 2024
- Added minor doc updates
- Added servicMonitor.yaml template
- Fixed services.yaml targetPort
@phsmith
Copy link
Owner

phsmith commented Jul 29, 2024

Okay, @naqshava, just send the fixes for the items you reported.
Whenever you get a chance, please pull the latest from the main branch and validate it.
Thanks for your support.

@phsmith
Copy link
Owner

phsmith commented Aug 31, 2024

Closing this issue, but feel free to open a new one if you're still having problems.

@phsmith phsmith closed this as completed Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants