Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project executions metrics not show all jobs info #4

Closed
rdoering opened this issue Nov 2, 2020 · 8 comments
Closed

Project executions metrics not show all jobs info #4

rdoering opened this issue Nov 2, 2020 · 8 comments

Comments

@rdoering
Copy link

rdoering commented Nov 2, 2020

The order of the labels are not correct.

@rdoering
Copy link
Author

rdoering commented Nov 2, 2020

This is already fixed in PR #3

@rdoering
Copy link
Author

rdoering commented Nov 3, 2020

I thougth about the current solution of Metrics and IMHO there is much room for improvements. For example: Currently the recent executions are fetch but just the first one is evaluated.

@phsmith
Copy link
Owner

phsmith commented Nov 3, 2020

I thougth about the current solution of Metrics and IMHO there is much room for improvements. For example: Currently the recent executions are fetch but just the first one is evaluated.

@rdoering on previous versions, the executions fetch returned more results, but as a recommendation from the Prometheus curators, these metrics must return only the last value. But we can review that logic.

@rdoering
Copy link
Author

rdoering commented Nov 3, 2020

I guess this is OK, but the execution endpoint is returning execution for all jobs in rundeck and we are showing just representing the latest execution of an arbitrary job.

I would like to address following question with the metric. "Was there a failing execution of job named abc?"

@rdoering
Copy link
Author

rdoering commented Nov 3, 2020

I would suggest to use the endpoint /api/14/project/[PROJECT]/executions as before but with the param "recentFilter". The result set could be represented as "current" state or we append the result set to the previous and represent the stored set as current state.

@phsmith
Copy link
Owner

phsmith commented Nov 4, 2020

@rdoering you're right. I understood what you're talking about.
I'm going to fix the project executions metrics to retrieve the status of all project jobs.

@phsmith phsmith changed the title Labels are assigned not correct Project executions metrics not show all jobs info Nov 4, 2020
phsmith added a commit that referenced this issue Nov 4, 2020
@phsmith
Copy link
Owner

phsmith commented Nov 4, 2020

@rdoering I've just release the version 2.1.0 with the recentFilter query as you suggested.
I've put recentFilter=1h.

@rdoering
Copy link
Author

rdoering commented Nov 4, 2020

@phsmith Thank you very much for your quick response. It is working like a charm.

@phsmith phsmith closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants