-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project executions metrics not show all jobs info #4
Comments
This is already fixed in PR #3 |
I thougth about the current solution of Metrics and IMHO there is much room for improvements. For example: Currently the recent executions are fetch but just the first one is evaluated. |
@rdoering on previous versions, the executions fetch returned more results, but as a recommendation from the Prometheus curators, these metrics must return only the last value. But we can review that logic. |
I guess this is OK, but the execution endpoint is returning execution for all jobs in rundeck and we are showing just representing the latest execution of an arbitrary job. I would like to address following question with the metric. "Was there a failing execution of job named abc?" |
I would suggest to use the endpoint /api/14/project/[PROJECT]/executions as before but with the param "recentFilter". The result set could be represented as "current" state or we append the result set to the previous and represent the stored set as current state. |
@rdoering you're right. I understood what you're talking about. |
@rdoering I've just release the version 2.1.0 with the recentFilter query as you suggested. |
@phsmith Thank you very much for your quick response. It is working like a charm. |
The order of the labels are not correct.
The text was updated successfully, but these errors were encountered: