Require PHPStan 1.7.0

phpstan · May 2, 2022 · 4855249 · 4855249
1 parent c0b61e2
commit 4855249
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 13 deletions.
diff --git a/composer.json b/composer.json
@@ -7,7 +7,7 @@
 	],
 	"require": {
 		"php": "^7.2 || ^8.0",
-		"phpstan/phpstan": "^1.6.3"
+		"phpstan/phpstan": "^1.7.0"
 	},
 	"require-dev": {
 		"nikic/php-parser": "^4.13.0",

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -62,16 +62,6 @@ parameters:
 			count: 1
 			path: src/Rules/Classes/RequireParentConstructCallRule.php
 
-		-
-			message: "#^Method PHPStan\\\\Rules\\\\Classes\\\\RequireParentConstructCallRule\\:\\:getParentConstructorClass\\(\\) has parameter \\$classReflection with generic class ReflectionClass but does not specify its types\\: T$#"
-			count: 1
-			path: src/Rules/Classes/RequireParentConstructCallRule.php
-
-		-
-			message: "#^Method PHPStan\\\\Rules\\\\Classes\\\\RequireParentConstructCallRule\\:\\:getParentConstructorClass\\(\\) return type with generic class ReflectionClass does not specify its types\\: T$#"
-			count: 1
-			path: src/Rules/Classes/RequireParentConstructCallRule.php
-
 		-
 			message: "#^Class PHPStan\\\\Rules\\\\DisallowedConstructs\\\\DisallowedBacktickRule implements generic interface PHPStan\\\\Rules\\\\Rule but does not specify its types\\: TNodeType$#"
 			count: 1

diff --git a/src/Rules/Classes/RequireParentConstructCallRule.php b/src/Rules/Classes/RequireParentConstructCallRule.php
@@ -7,9 +7,10 @@
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Analyser\Scope;
+use PHPStan\BetterReflection\Reflection\Adapter\ReflectionClass;
+use PHPStan\BetterReflection\Reflection\Adapter\ReflectionEnum;
 use PHPStan\Rules\Rule;
 use PHPStan\ShouldNotHappenException;
-use ReflectionClass;
 use function property_exists;
 use function sprintf;
 
@@ -114,9 +115,10 @@ private function callsParentConstruct(Node $parserNode): bool
 	}
 
 	/**
+	 * @param ReflectionClass|ReflectionEnum $classReflection
 	 * @return ReflectionClass|false
 	 */
-	private function getParentConstructorClass(ReflectionClass $classReflection)
+	private function getParentConstructorClass($classReflection)
 	{
 		while ($classReflection->getParentClass() !== false) {
 			$constructor = $classReflection->getParentClass()->hasMethod('__construct') ? $classReflection->getParentClass()->getMethod('__construct') : null;