Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused private property is not sometimes detected #3539

Merged
merged 4 commits into from
Oct 6, 2024
Merged

Fix unused private property is not sometimes detected #3539

merged 4 commits into from
Oct 6, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Oct 4, 2024

@staabm
Copy link
Contributor Author

staabm commented Oct 4, 2024 •
edited
Loading

Just realized we have the same bug in UnusedPrivateMethodRule - hold my beer

@staabm staabm marked this pull request as ready for review October 4, 2024 13:35
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit c6db9a9 into phpstan:1.12.x Oct 6, 2024
473 of 499 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@ondrejmirtes ondrejmirtes mentioned this pull request Oct 6, 2024
Closed
@staabm staabm deleted the bug11802 branch October 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staabm @phpstan-bot @ondrejmirtes