Refactor RegexGroupParser for more immutability and less pass-by-ref #3508
Conversation
clxmstaab
force-pushed
the
refa
branch
2 times, most recently
from
e283d69
to
aa6a193
Compare
|
This pull request has been marked as ready for review. |
|
//cc @mvorisek lets wait until a few of the open Regex-inference PRs are merged so we don't step on each others toes |
| { | ||
| return new self( | ||
| -1, | ||
| 100, |
There was a problem hiding this comment.
I know you moved the code only, but why 100?
There was a problem hiding this comment.
in the initial implementation there we so many arrays involved, that I used a different start-index to trigger php warnings in case I mixed up the keys between different arrays ;)
There was a problem hiding this comment.
please add a comment into the code
| ); | ||
| } | ||
|
|
||
| public function nextAlternationId(): self |
There was a problem hiding this comment.
name it better, it does not return int
There was a problem hiding this comment.
it returns a "copy" of the current object, which contains the next alternation id.
I think the name fits.
|
Thank you. |
less magic, less error prone
Part 2