Fix missing ltrim in regex parse #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Sep 26, 2024
|
Needs cs fix |
|
what cs fix? |
|
tell me how, seems unrelated to me: |
ondrejmirtes
requested changes
Sep 27, 2024
|
@ondrejmirtes as explained above, it cannot be currently tested |
|
I don't get it what's the purpose of this PR then. |
mvorisek
force-pushed
the
fix_missing_ltrim_regex
branch
from
9210422
to
756ec63
Compare
mvorisek
force-pushed
the
fix_missing_ltrim_regex
branch
from
756ec63
to
3eb2e46
Compare
mvorisek
force-pushed
the
fix_missing_ltrim_regex
branch
from
3eb2e46
to
dd8e963
Compare
|
@ondrejmirtes test added |
|
Now we have a failing unit test but I still don't understand what kind of issue this PR fixes. |
|
I understand that it does not currently fix a functional usecase, but it fixes internal hidden bug. It fixes a method behaviour that is needed for future implementations of regex shape narrowing as the initial delimiter needs to be properly removed per PCRE grammar. |
|
Alright, I get it. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.