-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connection_* functions are impure #2555
Conversation
bin/generate-function-metadata.php
Outdated
@@ -60,6 +61,21 @@ public function enterNode(Node $node) | |||
return null; | |||
} | |||
|
|||
private function isHasSideEffectsAnnotated(Attribute $attr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to a conversation with a contributor on JetBrains/phpstorm-stubs, the Pure
attribute has different semantics based on the 1st parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the regenerated function map changed a lot.. I am not 100% sure all these changes make sense - at least no tests fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I think I over-think this thing and I should instead just have added a new entry to the functionMetadata_original
.
This pull request has been marked as ready for review. |
This pull request has been marked as ready for review. |
18650b1
to
170ef0c
Compare
Thank you. |
requires JetBrains/phpstorm-stubs#1560