random_int and random_bytes are not deterministic

bin/functionMetadata_original.php

@@ -63,8 +63,12 @@
 	// continue functionMap.php, line 424
 	'count' => ['hasSideEffects' => false],
 	'sprintf' => ['hasSideEffects' => false],
+
+	// random functions, do not have side effects but are not deterministic
 	'mt_rand' => ['hasSideEffects' => true],
 	'rand' => ['hasSideEffects' => true],
+	'random_bytes' => ['hasSideEffects' => true],
+	'random_int' => ['hasSideEffects' => true],
 
 	// methods
 	'DateTime::createFromFormat' => ['hasSideEffects' => false],

resources/functionMetadata.php

@@ -1358,6 +1358,8 @@
 	'quotemeta' => ['hasSideEffects' => false],
 	'rad2deg' => ['hasSideEffects' => false],
 	'rand' => ['hasSideEffects' => true],
+	'random_bytes' => ['hasSideEffects' => true],
+	'random_int' => ['hasSideEffects' => true],
 	'range' => ['hasSideEffects' => false],
 	'rawurldecode' => ['hasSideEffects' => false],
 	'rawurlencode' => ['hasSideEffects' => false],

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -5765,6 +5765,11 @@ public function dataDoNotRememberImpureFunctions(): array
 		return $this->gatherAssertTypes(__DIR__ . '/data/do-not-remember-impure-functions.php');
 	}
 
+	public function dataBug4190(): array
+	{
+		return $this->gatherAssertTypes(__DIR__ . '/data/bug-4190.php');
+	}
+
 	/**
 	 * @dataProvider dataArrayFunctions
 	 * @param string $description
@@ -11401,6 +11406,7 @@ private function gatherAssertTypes(string $file): array
 	 * @dataProvider dataTernarySpecifiedTypes
 	 * @dataProvider dataBug560
 	 * @dataProvider dataDoNotRememberImpureFunctions
+	 * @dataProvider dataBug4190
 	 * @param string $assertType
 	 * @param string $file
 	 * @param mixed ...$args

tests/PHPStan/Analyser/data/bug-4190.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Bug4190;
+
+use function PHPStan\Analyser\assertType;
+
+function (): string
+{
+	if (random_int(0, 10) <= 5) {
+		return 'first try';
+	}
+
+	assertType('bool', random_int(0, 10) <= 5);
+
+	return 'foo';
+};