Refactor RequireFileExistsRuleTest to work like all other tests

phpstan · Sep 23, 2024 · 4605833 · 4605833
1 parent a72f752
commit 4605833
Showing 1 changed file with 4 additions and 21 deletions.
diff --git a/tests/PHPStan/Rules/Keywords/RequireFileExistsRuleTest.php b/tests/PHPStan/Rules/Keywords/RequireFileExistsRuleTest.php
@@ -16,18 +16,11 @@
 class RequireFileExistsRuleTest extends RuleTestCase
 {
 
-	private RequireFileExistsRule $rule;
-
-	public function setUp(): void
-	{
-		parent::setUp();
-
-		$this->rule = $this->getDefaultRule();
-	}
+	private string $currentWorkingDirectory = __DIR__ . '/../';
 
 	protected function getRule(): Rule
 	{
-		return $this->rule;
+		return new RequireFileExistsRule($this->currentWorkingDirectory);
 	}
 
 	public static function getAdditionalConfigFiles(): array
@@ -37,11 +30,6 @@ public static function getAdditionalConfigFiles(): array
 		];
 	}
 
-	private function getDefaultRule(): RequireFileExistsRule
-	{
-		return new RequireFileExistsRule(__DIR__ . '/../');
-	}
-
 	public function testBasicCase(): void
 	{
 		$this->analyse([__DIR__ . '/data/require-file-simple-case.php'], [
@@ -124,13 +112,8 @@ public function testRelativePathWithIncludePath(): void
 
 	public function testRelativePathWithSameWorkingDirectory(): void
 	{
-		$this->rule = new RequireFileExistsRule(__DIR__);
-
-		try {
-			$this->analyse([__DIR__ . '/data/require-file-relative-path.php'], []);
-		} finally {
-			$this->rule = $this->getDefaultRule();
-		}
+		$this->currentWorkingDirectory = __DIR__;
+		$this->analyse([__DIR__ . '/data/require-file-relative-path.php'], []);
 	}
 
 }