Fix function-map for PDOStatement pass-by-reference functions

Resolves phpstan/phpstan/issues/4714
phpstan · Mar 20, 2021 · 1991bc7 · 1991bc7
1 parent a53fc5e
commit 1991bc7
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 3 deletions.
diff --git a/resources/functionMap.php b/resources/functionMap.php
@@ -8476,9 +8476,9 @@
 'PDOException::getTraceAsString' => [''],
 'PDOStatement::__sleep' => ['array'],
 'PDOStatement::__wakeup' => ['void'],
-'PDOStatement::bindColumn' => ['bool', 'column'=>'mixed', '&rw_param'=>'mixed', 'type='=>'int', 'maxlen='=>'int', 'driverdata='=>'mixed'],
-'PDOStatement::bindParam' => ['bool', 'paramno'=>'mixed', '&rw_param'=>'mixed', 'type='=>'int', 'maxlen='=>'int', 'driverdata='=>'mixed'],
-'PDOStatement::bindValue' => ['bool', 'paramno'=>'mixed', 'param'=>'mixed', 'type='=>'int'],
+'PDOStatement::bindColumn' => ['bool', 'column'=>'mixed', '&w_param'=>'mixed', 'type='=>'int', 'maxlen='=>'int', 'driverdata='=>'mixed'],
+'PDOStatement::bindParam' => ['bool', 'parameter'=>'mixed', '&w_variable'=>'mixed', 'data_type='=>'int', 'length='=>'int', 'driver_options='=>'mixed'],
+'PDOStatement::bindValue' => ['bool', 'parameter'=>'mixed', 'value'=>'mixed', 'data_type='=>'int'],
 'PDOStatement::closeCursor' => ['bool'],
 'PDOStatement::columnCount' => ['int'],
 'PDOStatement::debugDumpParams' => ['void'],

diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -5700,6 +5700,11 @@ public function dataBug4545(): array
 		return $this->gatherAssertTypes(__DIR__ . '/data/bug-4545.php');
 	}
 
+	public function dataBug4714(): array
+	{
+		return $this->gatherAssertTypes(__DIR__ . '/data/bug-4714.php');
+	}
+
 	/**
 	 * @dataProvider dataArrayFunctions
 	 * @param string $description
@@ -11323,6 +11328,7 @@ private function gatherAssertTypes(string $file): array
 	 * @dataProvider dataBug4657
 	 * @dataProvider dataBug4707
 	 * @dataProvider dataBug4545
+	 * @dataProvider dataBug4714
 	 * @param string $assertType
 	 * @param string $file
 	 * @param mixed ...$args

diff --git a/tests/PHPStan/Analyser/data/bug-4714.php b/tests/PHPStan/Analyser/data/bug-4714.php
@@ -0,0 +1,24 @@
+<?php
+
+namespace Bug4714;
+
+use PHPStan\TrinaryLogic;
+use function PHPStan\Analyser\assertVariableCertainty;
+
+class Foo
+{
+	public function bar(\PDO $database): void
+	{
+		$statement = $database->prepare('SELECT `col` FROM `foo` WHERE `param` = :param');
+		$statement->bindParam(':param', $param);
+
+		assertVariableCertainty(TrinaryLogic::createYes(), $param);
+
+		$param = 1;
+
+		$statement->execute();
+		$statement->bindColumn('col', $col);
+
+		assertVariableCertainty(TrinaryLogic::createYes(), $col);
+	}
+}