PHP 8.3 compatibility checks.

[rajeshreeputra]

No description provided.

[stof]

Merging this is a no-go until PHP 8.3 is released as it would block us from doing releases. As said in #607, the way to try the PHP unreleased version is to use the --ignore-platform-req=php+ option of composer.

[Wirone]

@stof out of curiosity: why adding constraint for the next PHP version blocks the releases? 🤔

[stof]

Because for a mocking library, making a release that marks a PHP version as supported while it does not mock properly the code for the new version is a very bad idea.
As a mocking library, new language features often require adapting the library (and so are kind of BC breaks for us).

For devs wanting to try pre-release versions of 8.3, composer already provides exactly the feature you need for that (and testing newer PHP versions is the exact reason why this feature was introduced in composer, so it is the intended usage)

[Wirone]

Thank you very much for the explanation, totally makes sense 👍.

[keradus]

@stof, happy to share that 8.3 is now released ;)
but I bet you already aware ;)

[stof]

I would not make phpstan run on an unstable PHP version as it increases the risk of having issues in phpstan itself.

[rajeshreeputra]

update to run on 8.2 and 8.3 both

[stof]

there is no reason to run phpstan on 2 different PHP versions IMO, except wasting compute resources for each CI build.

[glo71317]

@stof Any plan to merge this PR because we are blocked due to this dependency in our code base.

[stof]

@glo71317 my previous review comments are still relevant. We won't be releasing a version saying PHP 8.3 works right now. To try RC versions, the way to go is to use --ignore-platform-req=php+

[kylekatarnls]

It's released for a week now, this package is the only one still blocking to upgrade PHP without work-around at the moment some of the projects I work on. 🙏

[kylekatarnls]

On another note, waiting for a PHP version to be stable-release to support it in a library sounds ultra-drastic to me. Most of the libraries just test in advance coming versions to ensure they are compatible, most of them also use range such as ^8.1 that just allow whatever <9 and depending on how deprecation are anticipated (for instance adding 8.4 to Github Actions now allow to test with the dev branch of PHP and detect incompatibility ahead before it can impact users of the library), updating can be actually smoother with a major range compatibility.

I don't say it's the only way, just raising alternatives in case it were not investigated in details.

[stof]

@kylekatarnls See my previous comment in #608 (comment) about why using ^8.1 is not an option for Prophecy.

And for testing the dev branch of PHP, I already highlighted multiple times the --ignore-platform-req=php+ option of composer which is precisely about allowing such testing.
Note that for a mocking library, running our existing testsuite on a new version of PHP is not enough to know that we support the new version (this generally goes well). The complex part is figuring out whether mocking classes that use the new features of the language works well.

[Wirone]

@kylekatarnls PHP is not SemVer, so using open constraints like ^8.1 is discouraged, especially for mocking library that needs to be up-to-date with language's syntax and features.

@stof but wouldn't it be possible to prepare internal test cases that just utilise PHP 8.3 features and verify if everything works? In Fixer we also don't use PHP 8.3 features (code is 7.4-compatible), but we have integration test that verifies if fixer properly fixes files with 8.3 syntax. Is it possible in Prophecy to prepare such tests?

[stof]

@Wirone The issue is that since months that we said that this is the kind of checks that are needed to be able to know whether PHP 8.3 works fine (see #607), nobody in the community made such tests (or at least nobody reported the result to the repo if they tried it in separate codebase). It is not that it is not possible to do it. The issue is that it is not done.

[maxhelias]

I use the --ignore-platform-req=php+ option on phone-number-bundle to get the tests on the development version : https://github.com/odolbeau/phone-number-bundle/blob/master/.github/workflows/tests.yml#L27
Of course, there aren't many tests, but we have nothing to report on prophesize.