Namespace system package #2 #567
Conversation
|
The inspection completed: No issues found |
|
@terrafrost I think that get_class should be removed and replaced with "instanceof" across the board. I think it should be a separate PR though. |
| @@ -52,45 +52,6 @@ | |||
| // Used to do Diffie-Hellman key exchange and DSA/RSA signature verification. | |||
| use \phpseclib\Math\BigInteger; | |||
|
|
|||
| /**#@+ | |||
There was a problem hiding this comment.
Again, what is going on here? Is this a leftover from somewhere else?
There was a problem hiding this comment.
Yes, somehow those defines got put back in... It is in the current php5 branch.
There was a problem hiding this comment.
I don't think they were ever removed. See https://github.com/phpseclib/phpseclib/blame/php5/phpseclib/Net/SSH2.php
There was a problem hiding this comment.
And indeed they were not part of https://github.com/phpseclib/phpseclib/pull/532/files#diff-4. Similar SSH1 constants have been removed, though.
Namespace system package phpseclib#2 * cnelissen/NamespaceSystemPackage: Namespaced classes
|
This is good to go. Thanks a lot. |
This PR adds namespaces to all the System* classes and implements PSR-4 autoloading.
Rebased.