Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bad Request problem #6

Merged
merged 5 commits into from
Mar 27, 2020
Merged

Add Bad Request problem #6

merged 5 commits into from
Mar 27, 2020

Conversation

Landerstraeten
Copy link
Contributor

@Landerstraeten Landerstraeten commented Mar 17, 2020 •
edited
Loading

Hi

This PR would be a shorter version for:

new HttpApiProblem(400, ['detail' => 'a reason']);

@Landerstraeten Landerstraeten requested a review from veewee March 17, 2020 09:16
@Landerstraeten Landerstraeten added the enhancement New feature or request label Mar 17, 2020
@veewee
Copy link
Contributor

veewee commented Mar 17, 2020

Thanks for the PR! Looks good, can you also take a look at the tests + add documentation?

@Landerstraeten Landerstraeten mentioned this pull request Mar 27, 2020
Merged
veewee
veewee reviewed Mar 27, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@veewee veewee added this to the 1.3.0 milestone Mar 27, 2020
@veewee veewee merged commit 44126d0 into phpro:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Landerstraeten @veewee