Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP80 #11

Merged
merged 1 commit into from
Nov 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/ISSUE_TEMPLATE/Bug.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
---
name: 🐞 Bug Report
about: Something is broken? 🔨
---

### Bug Report

<!-- Fill in the relevant information below to help triage your issue. -->

| Q | A
|------------ | ------
| BC Break | yes/no
| Version | x.y.z

#### Summary

<!-- Provide a summary describing the problem you are experiencing. -->

#### Current behaviour

<!-- What is the current (buggy) behaviour? -->

#### How to reproduce

<!--
Provide steps to reproduce the bug.
If possible, also add a code snippet with relevant configuration, driver/platform information, SQL queries, etc.
Adding a failing Unit or Functional Test would help us a lot - you can submit one in a Pull Request separately, referencing this bug report.
-->

#### Expected behaviour

<!-- What was the expected (correct) behaviour? -->

18 changes: 18 additions & 0 deletions .github/ISSUE_TEMPLATE/Feature_Request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
name: 🎉 Feature Request
about: You have a neat idea that should be implemented? 🎩
---

### Feature Request

<!-- Fill in the relevant information below to help triage your issue. -->

| Q | A
|------------ | ------
| New Feature | yes
| RFC | yes/no
| BC Break | yes/no

#### Summary

<!-- Provide a summary of the feature you would like to see implemented. -->
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE/Support_Question.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
name: ❓ Support Question
about: Have a problem that you can't figure out? 🤔
---

<!-- Fill in the relevant information below to help triage your issue. -->

| Q | A
|------------ | -----
| Version | x.y.z


### Support Question

<!-- Describe the issue you are facing here. -->
11 changes: 11 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!-- Fill in the relevant information below to help triage your pull request. -->

| Q | A
|------------- | -----------
| Type | bug/feature/improvement
| BC Break | yes/no
| Fixed issues | <!-- use #NUM format to reference an issue -->

#### Summary

<!-- Provide a summary of your change. -->
53 changes: 53 additions & 0 deletions .github/workflows/grumphp.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
name: GrumPHP

on: [push, pull_request]
jobs:
run:
runs-on: ${{ matrix.operating-system }}
strategy:
matrix:
operating-system: [ubuntu-latest]
php-versions: ['7.3', '7.4', '8.0']
composer-options: ['', '--prefer-lowest']
fail-fast: false
name: PHP ${{ matrix.php-versions }} @ ${{ matrix.operating-system }} with ${{ matrix.composer-options }}
steps:
- name: Checkout
uses: actions/checkout@master
- name: Install PHP
uses: shivammathur/setup-php@master
with:
php-version: ${{ matrix.php-versions }}
tools: 'composer:v2'
extensions: pcov, mbstring, posix
- name: Check Versions
run: |
php -v
php -m
composer --version
- name: Get composer cache directory
id: composercache
run: echo "::set-output name=dir::$(composer config cache-files-dir)"
- name: Cache dependencies
uses: actions/cache@v2
with:
path: ${{ steps.composercache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
restore-keys: ${{ runner.os }}-composer-
- name: Install dependencies <PHP8
if: matrix.php-versions != '8.0'
run: composer update --prefer-dist --no-progress --no-suggest ${{ matrix.composer-options }}
#
# Currently php-cs-fixer is nog PHP 8 compatible yet!
#
- name: Install dependencies PHP8
if: matrix.php-versions == '8.0'
run: composer update --prefer-dist --no-progress --no-suggest ${{ matrix.composer-options }} --ignore-platform-reqs
- name: Set git variables
run: |
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
- name: Run the tests
run: php vendor/bin/grumphp run --no-interaction
env:
PHP_CS_FIXER_IGNORE_ENV: ${{ matrix.php-versions == '8.0'}}
27 changes: 0 additions & 27 deletions .travis.yml

This file was deleted.

8 changes: 4 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"description": "RFC7807 Problem details implementation",
"type": "library",
"require-dev": {
"friendsofphp/php-cs-fixer": "^2.12",
"phpro/grumphp": "^0.17",
"phpspec/phpspec": "^6.0",
"friendsofphp/php-cs-fixer": "^2.16.7",
"phpro/grumphp-shim": "^1.2",
"phpspec/phpspec": "^6.3",
"symfony/validator": "^4.4",
"sebastian/comparator": "^1.2.4"
},
Expand All @@ -17,7 +17,7 @@
}
],
"require": {
"php": "^7.2"
"php": "^7.3 || ^8.0"
},
"config": {
"sort-packages": true
Expand Down
4 changes: 1 addition & 3 deletions grumphp.yml.dist
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
parameters:
git_dir: .
bin_dir: vendor/bin
grumphp:
tasks:
phpcsfixer2:
config: ".php_cs.dist"
Expand Down