-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group lists by category feature #426
Conversation
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
I will resolve merge conflicts. |
@xh3n1 Can you remove the extra margin at the bottom of lists? Currently they make the accordion section content have unbalanced whitespace at top and bottom of the section. |
…n wording; Add label to lists sub-section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change the following behavior:
Currently if a Category has only private lists assigned to it will still be shown as a category in the front-end.
We should only display categories that have at least on public list assigned.
@samtuke it's not the list name that's repeated, it's the description. |
oh, i see what you mean, I'm checking now. |
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@suelaP it was happening only when lists were not selected on the subscribe page (all public lists displayed all by default), but I committed a change and it should be good now. |
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@samtuke I added the default setting on configuration page |
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
-phpList/phplist-ui-bootlist#74 needs to be merged for lists to be split into two columns.