Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group lists by category feature #426

Merged
merged 17 commits into from
Oct 31, 2018
Merged

Group lists by category feature #426

merged 17 commits into from
Oct 31, 2018

Conversation

xh3n1
Copy link
Collaborator

@xh3n1 xh3n1 commented Oct 25, 2018

-phpList/phplist-ui-bootlist#74 needs to be merged for lists to be split into two columns.

xh3n1 added 11 commits October 16, 2018 21:31
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@xh3n1
Copy link
Collaborator Author

xh3n1 commented Oct 25, 2018

I will resolve merge conflicts.

@samtuke samtuke requested a review from suelaP October 25, 2018 16:04
@samtuke
Copy link
Collaborator

samtuke commented Oct 26, 2018

@xh3n1 Can you remove the extra margin at the bottom of lists? Currently they make the accordion section content have unbalanced whitespace at top and bottom of the section.
workspace 1_496

Copy link
Member

@suelaP suelaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the following behavior:
Currently if a Category has only private lists assigned to it will still be shown as a category in the front-end.
We should only display categories that have at least on public list assigned.

@samtuke
Copy link
Collaborator

samtuke commented Oct 26, 2018

Currently the list name is repeated twice, and the list description isn't stated (when group by categories is used).
selection_498

@xh3n1
Copy link
Collaborator Author

xh3n1 commented Oct 26, 2018

@samtuke it's not the list name that's repeated, it's the description.

@xh3n1
Copy link
Collaborator Author

xh3n1 commented Oct 26, 2018

oh, i see what you mean, I'm checking now.

xh3n1 added 2 commits October 26, 2018 13:51
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@xh3n1
Copy link
Collaborator Author

xh3n1 commented Oct 26, 2018

@suelaP it was happening only when lists were not selected on the subscribe page (all public lists displayed all by default), but I committed a change and it should be good now.

Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@xh3n1
Copy link
Collaborator Author

xh3n1 commented Oct 28, 2018

screen shot 2018-10-28 at 19 40 47

@samtuke I added the default setting on configuration page

@xh3n1
Copy link
Collaborator Author

xh3n1 commented Oct 29, 2018

@samtuke I pushed a commit here for the bottom margin.

Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
@samtuke
Copy link
Collaborator

samtuke commented Oct 31, 2018

This feature in action (depends on changes to bootlist/trevelin theme also):

Per-list settings:
screenshot_2018-10-31 phplist 1

Global setting:
screenshot_2018-10-31 phplist

Example subscribe page single column:
screenshot_2018-10-31 subscribe to our newsletters 1

Example subscribe page dual column:
screenshot_2018-10-31 subscribe to our newsletters

@samtuke samtuke merged commit 62f3704 into master Oct 31, 2018
@samtuke samtuke deleted the categories-feature branch October 31, 2018 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants