feat: CI job for building Docker binary-only images #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
reviewed
Nov 21, 2024
TimWolla
suggested changes
Nov 21, 2024
asgrim
reviewed
Nov 22, 2024
Wirone
force-pushed
the
codito/docker-builds
branch
2 times, most recently
from
76493bf to
7eb5264
Compare
Wirone
commented
Nov 22, 2024
asgrim
added
the
maintainer feedback needed
TimWolla
reviewed
Nov 22, 2024
Wirone
force-pushed
the
codito/docker-builds
branch
from
7eb5264 to
61e4a07
Compare
asgrim
requested changes
Nov 29, 2024
asgrim
reviewed
Nov 29, 2024
Wirone
force-pushed
the
codito/docker-builds
branch
4 times, most recently
from
777c6d9 to
47de137
Compare
Wirone
force-pushed
the
codito/docker-builds
branch
from
47de137 to
e0c258d
Compare
asgrim
reviewed
Nov 29, 2024
|
@asgrim Docker build attestation from latest build can be found here. |
TimWolla
reviewed
Dec 3, 2024
There was a problem hiding this comment.
I'm still concerned about https://github.com/php/pie/pull/122/files#r1854054535, given that we only make the Phar available as “latest” and as a specific version, not by any “major” / “minor” wildcards.
The workflow steps look fine to me, except for the few remarks I've made.
TimWolla
reviewed
Dec 3, 2024
|
@TimWolla @asgrim tested new release, images have been built correctly, you can see them in the registry.
|
asgrim
reviewed
Dec 4, 2024
Wirone
force-pushed
the
codito/docker-builds
branch
from
460f0c3 to
61ba6a8
Compare
TimWolla
approved these changes
Dec 4, 2024
|
@TimWolla after @keradus' reviews nothing seems to be annoying 😂. But seriously, thanks for the great feedback, I've learned new things during the process so for me this was added value. I like good code reviews 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to composer/docker#250 (more info), this PR introduces a CI process for releasing binary-only images for Pie 🥳!
You can see the result here, there is an image in my fork's Package Registry, built here.
Here's how the image looks like (
dive ghcr.io/wirone/php-pie:latest-bin):PS: I decided to not verify GPG signature during build because we can trust our own workflow (we copy PHAR file built in previous stage), but also I had some problems with verification (GPG imported correctly, but verification failed). Users may verify the file on their own, if they want, using attachedSigning was dropped.pie.asc.Fixes #137