Finish template types for the WP_REST_Request methods #186
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @lipemat! @IanDelMar Please add your review. I'll click on Merge right away. |
IanDelMar
reviewed
Jul 14, 2024
IanDelMar
reviewed
Jul 14, 2024
IanDelMar
reviewed
Jul 14, 2024
IanDelMar
reviewed
Jul 14, 2024
Co-authored-by: IanDelMar <42134098+IanDelMar@users.noreply.github.com>
Co-authored-by: IanDelMar <42134098+IanDelMar@users.noreply.github.com>
Co-authored-by: IanDelMar <42134098+IanDelMar@users.noreply.github.com>
Co-authored-by: IanDelMar <42134098+IanDelMar@users.noreply.github.com>
|
Thank you Space Officer! |
|
@szepeviktor You are too fast! I haven't finished the review yet. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template types previously existed for the
ArrayAccessmodifiers but not much else in the way of direct method calls.This branch adds additional method types for the general
get/set/hasmethods in the class.Also added a few unit tests.