Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right margin when menu is shrunk #223

Merged
merged 2 commits into from
Dec 24, 2019
Merged

Add right margin when menu is shrunk #223

merged 2 commits into from
Dec 24, 2019

Conversation

AydinHassan
Copy link
Member

  • fix bug with maybeResize using margin when in auto mode

@codecov-io
Copy link

codecov-io commented Dec 24, 2019

Codecov Report

Merging #223 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #223      +/-   ##
============================================
+ Coverage     93.06%   93.09%   +0.02%     
- Complexity      605      608       +3     
============================================
  Files            31       32       +1     
  Lines          1789     1796       +7     
============================================
+ Hits           1665     1672       +7     
  Misses          124      124
Impacted Files Coverage Δ Complexity Δ
src/Exception/CannotShrinkMenuException.php 100% <100%> (ø) 1 <1> (?)
src/MenuStyle.php 96.7% <100%> (+0.01%) 77 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0283b18...3f7aba7. Read the comment docs.

@AydinHassan
Copy link
Member Author

@jtreminio this fixes the right margin issue

@AydinHassan AydinHassan merged commit 36767e4 into master Dec 24, 2019
@AydinHassan AydinHassan deleted the right-margin branch December 24, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants