-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selectable item styles #214
Selectable item styles #214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
============================================
- Coverage 93.52% 93.29% -0.23%
- Complexity 558 589 +31
============================================
Files 30 31 +1
Lines 1667 1760 +93
============================================
+ Hits 1559 1642 +83
- Misses 108 118 +10
Continue to review full report at Codecov.
|
@@ -396,22 +397,25 @@ public function setMargin(int $margin) : self | |||
public function setUnselectedMarker(string $marker) : self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just drop these methods. It's just a little BC break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needed for MenuMenuItem. I can completely drop in next PR for that item's style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great, sounds good.
Everything else looks good! |
No description provided.