Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable item styles #214

Merged
merged 5 commits into from
Dec 20, 2019

Conversation

jtreminio
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #214 into master will decrease coverage by 0.22%.
The diff coverage is 91.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #214      +/-   ##
============================================
- Coverage     93.52%   93.29%   -0.23%     
- Complexity      558      589      +31     
============================================
  Files            30       31       +1     
  Lines          1667     1760      +93     
============================================
+ Hits           1559     1642      +83     
- Misses          108      118      +10
Impacted Files Coverage Δ Complexity Δ
src/Style/RadioStyle.php 100% <ø> (ø) 12 <0> (ø) ⬇️
src/MenuItem/SelectableItem.php 100% <100%> (ø) 16 <11> (+11) ⬆️
src/Style/SelectableStyle.php 100% <100%> (ø) 12 <12> (?)
src/CliMenu.php 95.34% <100%> (+0.09%) 115 <2> (+2) ⬆️
src/Builder/CliMenuBuilder.php 77.73% <52.94%> (-1.84%) 89 <3> (+6)
src/MenuItem/SelectableTrait.php 92.3% <0%> (-7.7%) 9% <0%> (ø)
src/MenuItem/CheckboxItem.php 92.72% <0%> (ø) 20% <0%> (ø) ⬇️
src/MenuItem/RadioItem.php 100% <0%> (ø) 21% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3342279...09b4294. Read the comment docs.

@@ -396,22 +397,25 @@ public function setMargin(int $margin) : self
public function setUnselectedMarker(string $marker) : self
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just drop these methods. It's just a little BC break.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed for MenuMenuItem. I can completely drop in next PR for that item's style.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok great, sounds good.

@AydinHassan
Copy link
Member

Everything else looks good!

@AydinHassan AydinHassan merged commit 4992019 into php-school:master Dec 20, 2019
@jtreminio jtreminio deleted the feature/selectable-style branch December 20, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants