-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds RadioItem and ToggableTrait #194
Conversation
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
============================================
- Coverage 93.2% 93.08% -0.12%
- Complexity 491 516 +25
============================================
Files 27 29 +2
Lines 1486 1562 +76
============================================
+ Hits 1385 1454 +69
- Misses 101 108 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few redundant docs, i'll remove them. Thanks a lot, looks great!
/** | ||
* Gets checked state | ||
* | ||
* @return bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant doc
/** | ||
* The output text for the item | ||
* | ||
* @param MenuStyle $style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant docs
Missing fancy screenshot.
Also adds
SpliItemTest::testCheckableItem()