Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RadioItem and ToggableTrait #194

Merged
merged 6 commits into from
Dec 17, 2019

Conversation

jtreminio
Copy link
Contributor

Missing fancy screenshot.

Also adds SpliItemTest::testCheckableItem()

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #194 into master will decrease coverage by 0.11%.
The diff coverage is 86.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
- Coverage      93.2%   93.08%   -0.12%     
- Complexity      491      516      +25     
============================================
  Files            27       29       +2     
  Lines          1486     1562      +76     
============================================
+ Hits           1385     1454      +69     
- Misses          101      108       +7
Impacted Files Coverage Δ Complexity Δ
src/MenuItem/CheckableItem.php 100% <ø> (+8.33%) 9 <0> (-10) ⬇️
src/CliMenu.php 90.39% <0%> (-2.65%) 109 <4> (+4)
src/MenuItem/RadioItem.php 100% <100%> (ø) 10 <10> (?)
src/Builder/SplitItemBuilder.php 78.04% <100%> (+1.73%) 12 <1> (+1) ⬆️
src/MenuItem/ToggableTrait.php 100% <100%> (ø) 11 <11> (?)
src/MenuStyle.php 97.27% <100%> (+0.13%) 78 <4> (+4) ⬆️
src/MenuItem/SplitItem.php 100% <100%> (+2.32%) 47 <0> (+2) ⬆️
src/Builder/CliMenuBuilder.php 81.9% <33.33%> (-2.18%) 70 <3> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867de8a...ca2712d. Read the comment docs.

Copy link
Member

@AydinHassan AydinHassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few redundant docs, i'll remove them. Thanks a lot, looks great!

/**
* Gets checked state
*
* @return bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant doc

/**
* The output text for the item
*
* @param MenuStyle $style
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant docs

@AydinHassan AydinHassan merged commit 1b78207 into php-school:master Dec 17, 2019
@jtreminio jtreminio deleted the feature/radio-item branch December 17, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants