Item extra toggling support #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
============================================
+ Coverage 93.19% 93.22% +0.02%
- Complexity 486 488 +2
============================================
Files 27 27
Lines 1470 1475 +5
============================================
+ Hits 1370 1375 +5
Misses 100 100
Continue to review full report at Codecov.
|
|
seems fair to me 👍 |
|
Looks like this solves the issue. |
AydinHassan
force-pushed
the
item-extra-toggling
branch
from
ead500a to
b2febc9
Compare
This was referenced Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jtreminio would this solve the problem for you?
Basically we previously inferred whether to display item extra based on the items in the menu. If no items displayed item extra then we disabled it globally.
I've added a method to the builder to force display item extra and if you customise the item extra text it will enable it globally also.
/cc @mikeymike @polothy (only two years late :D)
I'll add some tests and docs if everyone is happy with this.