Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 to CI matrix #17

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add PHP 8.4 to CI matrix #17

merged 1 commit into from
Nov 26, 2024

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 26, 2024

@dbu Could you please merge this, and then tag a new release?

I need c6975e5 to be able to run this on PHP 8.4

PHP Deprecated: Http\Adapter\Guzzle7\Promise::then(): Implicitly marking parameter $onFulfilled as nullable is deprecated, the explicit nullable type must be used instead in vendor/php-http/guzzle7-adapter/src/Promise.php on line 76

@dbu dbu merged commit 93243a3 into php-http:1.x Nov 26, 2024
10 of 11 checks passed
@dbu
Copy link
Contributor

dbu commented Nov 26, 2024

thanks!

@dbu
Copy link
Contributor

dbu commented Nov 26, 2024

@ruudk ruudk deleted the patch-1 branch November 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants