Allowing use of DSN for redis and mongo factories #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (empty($config['dsn'])) { | ||
| $manager = new Manager(sprintf('mongodb://%s:%s', $config['host'], $config['port'])); | ||
| } else { | ||
| $manager = new Manager($config['dsn']); |
|
Cool solution with the DSN object. Maybe you could override the validate function to make sure we validate the DSN on build time? /**
* {@inheritdoc}
*/
public static function validate(array $options, $adapterName)
{
parent::validate(options, adapterName);
if (empty($options['dsn'])) {
return;
}
$dsn = new DSN($options['dsn']);
if (!$dsn->isValid()) {
throw new \InvalidArgumentException('Invalid DSN: '.$config['dsn']);
}
} |
|
|
||
| private function parseProtocol($dsn) | ||
| { | ||
| $regex = '/^(redis|mysql|mongodb|tcp):\/\//i'; |
There was a problem hiding this comment.
Should we be more generic with?:
$regex = '|^(.*?)://|i';There was a problem hiding this comment.
That would allow for any protocol to be considered valid. I only want redis, mysql, mongodb, and tcp to be considered valid for now
| use Symfony\Component\OptionsResolver\OptionsResolver; | ||
|
|
||
| /** | ||
| * @author Tobias Nyholm <tobias.nyholm@gmail.com> |
|
Nice work. The DSN factory really makes sen and made the code cleaner. |
Creating AbstractDsnAdapterFactory Updating DSN to parse multiple hosts. Adding tests for DSN
cryptiklemur
added a commit
that referenced
this pull request
Jan 27, 2016
Allowing use of DSN for redis and mongo factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: php-cache/issues#26