Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO improvements #634

Merged
merged 1 commit into from
Feb 27, 2019
Merged

IO improvements #634

merged 1 commit into from
Feb 27, 2019

Conversation

ramunasd
Copy link
Member

@ramunasd ramunasd commented Dec 16, 2018 •
edited
Loading

  • fix unhandled warning in SocketIO on failed connect
  • add heartbeat support for socket connections
  • move common methods and properties to abstract class
  • fix docblocks

@lukebakken lukebakken self-assigned this Dec 17, 2018
@lukebakken lukebakken added this to the 2.8.2 milestone Dec 17, 2018
lukebakken
lukebakken requested changes Feb 18, 2019
View reviewed changes
PhpAmqpLib/Wire/IO/SocketIO.php Outdated Show resolved Hide resolved
@lukebakken lukebakken modified the milestones: 2.8.2, 2.9.0 Feb 18, 2019
@ramunasd
Copy link
Member Author

I will rebase everything after #642

@lukebakken
Copy link
Collaborator

@ramunasd - #642 is merged, thanks again for that fix.

@ramunasd
Copy link
Member Author

More duplicated code resolved.
Looks like HHVM 4.0 is out but composer is not compatible and build fails:

Fatal error: Uncaught exception 'InvalidArgumentException' with message 'array_pop() expects parameter 1 by reference, but the call was not annotated with '&'' in phar://composer.phar/bin/../src/../src/Composer/Util/Silencer.php:51

It is possible to define hhvm version https://docs.travis-ci.com/user/languages/php/#hhvm-versions-are-available-on-trusty-only

Are we gonna support old hhvm versions only?

@lukebakken
Copy link
Collaborator

Are we gonna support old hhvm versions only?

I don't think there's a problem with dropping hhvm testing if Travis doesn't support it.

@ramunasd ramunasd force-pushed the wire_improvements branch 3 times, most recently from c3bcf76 to 71d87e4 Compare February 23, 2019 10:03
@lukebakken lukebakken force-pushed the wire_improvements branch 2 times, most recently from 91c6e10 to 68b9898 Compare February 25, 2019 21:04
@lukebakken lukebakken added this to the 2.9.0 milestone Feb 25, 2019
@ramunasd ramunasd force-pushed the wire_improvements branch 2 times, most recently from 537cfe7 to 9db64a0 Compare February 25, 2019 21:48
@ramunasd
fix unhandled warning in SocketIO & missing heartbeat check, move com…
df4ba35 
…mon methods to abstract class, fix docblocks and connection inheritance
@ramunasd
Copy link
Member Author

rebased on latest master

@lukebakken lukebakken merged commit 411dc08 into php-amqplib:master Feb 27, 2019
@lukebakken
Copy link
Collaborator

Thank you!

@ramunasd
Copy link
Member Author

This lib is getting better and better. Thank You Luke Bakken for maintainership.

@ramunasd ramunasd deleted the wire_improvements branch March 11, 2019 13:54
kratkyzobak pushed a commit to kratkyzobak/php-amqplib that referenced this pull request Feb 9, 2024
@lukebakken
Merge pull request php-amqplib#634 from ramunasd/wire_improvements
4fd0b0d 
IO improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken requested changes

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ramunasd @lukebakken