Fix Error processing task: classify.style #320 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-F
force-pushed
the
320-fix-error-processing-task-classify.style
branch
from
40c349b to
2b71f82
Compare
|
Added a fix for photos with more than three channels (like CMYK) and squashed/re-based |
|
Looks great. Thanks @Red-F. I'll be sure to try it out and make some test cases for this - hopefully soon. |
damianmoore
approved these changes
Sep 1, 2021
|
Merged and test added as of 53ef6f2 |
|
Thanks @Red-F very much for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #320
The change is a lot smaller than the Git diff suggests :( It basically catches exceptions from tensor reading from file and then returning None since no result can be constructed. In addition the None results are handled when running as a Task or running stand-alone.