Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Clear inbox messages list when clicking action button #2705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpalou
Copy link

@dpalou dpalou commented Feb 11, 2019

Description

Right now, clicking an action button with foreground=false doesn't clear the list of messages of an inbox notification, the only thing it does is dismiss the notification. If you receive a new notification, the full list is displayed again.

With this patch the list is cleared when an action button is clicked. This affects inline replies too.

Related Issue

#2699

Motivation and Context

The list of messages should be cleared when clicking an action button, otherwise the user will see the same notifications over and over again.

How Has This Been Tested?

I didn't find any Jasmine test about inbox notifications, so I tested it manually in:

  • Honor 8 with Android 7.
  • Android Simulator: Pixel XL with API 27.

The changes are quite small and shouldn't affect other areas of the code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant