Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c:Phoenix.Endpoint.server_info/1 #5620

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

mtrudel
Copy link
Member

@mtrudel mtrudel commented Nov 1, 2023

Solves #5553

Paired with mtrudel/bandit#258 over in Bandit-land

@mtrudel will follow with a change to refactor livebook-dev/livebook#2316 once this is merged/released (@josevalim relevant to your recent interests)

@josevalim
Copy link
Member

Thank @mtrudel. I am thinking this should be a single function, called server_info(:http | :https). WDYT?

@josevalim
Copy link
Member

Perhaps it should be server_info(:http | :https) :: {:ok, address, port} | {:local, path} | {:error, reason}

@mtrudel
Copy link
Member Author

mtrudel commented Nov 2, 2023

I am thinking this should be a single function, called server_info(:http | :https)

Yep; I'll work that up; won't take a few minutes.

@mtrudel mtrudel force-pushed the adapter_improvements branch from 9c4ecb4 to c522042 Compare November 2, 2023 13:21
@mtrudel mtrudel changed the title Add c:Phoenix.Endpoint.address/1 and c:Phoenix.Endpoint.port/1 Add c:Phoenix.Endpoint.server_info/1 Nov 2, 2023
@mtrudel
Copy link
Member Author

mtrudel commented Nov 2, 2023

Revised and ready to go!

@josevalim josevalim merged commit 932d2e5 into phoenixframework:main Nov 2, 2023
4 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants