Do not run swoosh memory storage process in production #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hermanverschooten
force-pushed
the
do_not_start_swoosh_local_in_production
branch
from
73ee8f0
to
7f7ddca
Compare
|
❤️❤️❤️🐥🔥 |
varshneydevansh
added a commit
to varshneydevansh/phoenix
that referenced
this pull request
Jun 20, 2023
varshneydevansh
added a commit
to varshneydevansh/phoenix
that referenced
this pull request
Jun 20, 2023
This reverts commit 331b781.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swoosh starts an in memory storage for mails by default
I do not think anybody uses this in production, so I think adding this to the generated
prod.exsfile makes sense.