support for node-20 #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would love to have this merged |
|
Can you please merge this ASAP |
saurabh-gadariya
approved these changes
Mar 14, 2024
JakeTowers
approved these changes
Mar 14, 2024
JakeTowers
force-pushed
the
feature/node-20
branch
2 times, most recently
from
be4b7f2 to
c46ec5b
Compare
JakeTowers
force-pushed
the
feature/node-20
branch
from
f6111af to
a9c5792
Compare
|
@IanMoroney not sure why the build is failing on this, I opened a new branch with the exact same changes and the build succeeds... I thought it was to do with GitHub permissions needed as it seems to fail here - https://github.com/phoenix-actions/test-reporting/blob/main/src/main.ts#L186-L195 and that says it needs the |
|
there is a permission now required @JakeTowers in the ci workflow. |
|
committed the required change to main |
|
Tested successfully in #47 . Merged to main, so will close the PR in favour of that one with successful CI builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
This is a breaking change, see hashicorp/vault-action#526