Enable outputting the replacement value on PDFs #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessieAMorris
force-pushed
the
feature/pdf-labeling
branch
from
9fa3fa9 to
d6bfe7f
Compare
JessieAMorris
commented
Dec 17, 2024
Comment on lines
250
to
251
| var replacementText = rectangle.getSpan().getReplacement(); | ||
| var rectangleWidth = rectangle.getPdRectangle().getWidth(); |
There was a problem hiding this comment.
I haven't seen much var usage in the project, so I'm happy to change this if requested.
JessieAMorris
force-pushed
the
feature/pdf-labeling
branch
from
d6bfe7f to
5028c48
Compare
|
I think my initial thought is to have it disabled by default since it changes how things are redacted. My thought is for existing users they would have to go disable it after discovering it. But I'm open to other thoughts on that. I wrote #181 to capture the documentation task. |
|
Sounds good, I'll get that changed so the default remains. |
|
Okay, I've added disabling by default, did a minor refactor, and added documentation. I did slightly rename the arguments to make them a bit more obvious what their behavior actually does. |
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables outputting/replacing the text in PDFs by including the replacement value inside of the redaction box.
Best efforts are given to ensure that the text does not expand beyond the bounds of the box. This does, however, create scenarios where the box is really small so the font size ends up being tiny and not supremely useful.
Somewhat readable example:
Indecipherable example:
I'm wondering if this is something that should be disabled by default.
There also needs to be some documentation written for the PDF configuration portion of the policy.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.