New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate ThreadContext.num_workers #3

Open

cydanil wants to merge 1 commit into philsmt:master from cydanil:feat/handle_zero

cydanil commented Nov 10, 2021

Here is a possible improvement validating the given ThreadContext.num_workers at initialization.

Messing around with AGIPD notebooks, I noticed that the notebook may assign 0 threads if there's more files than cores availables.

It's most likely a non-issue but ~~it's a slow shift~~ it's a simple validation to add here.

I've tested the changes as seen in the test file.

Thanks!
Cyril


          Validate ThreadContext.num_workers

40c9eb5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet