Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

predict.lcModel() result can trigger error in transformPredict() #120

Closed
niekdt opened this issue Jun 30, 2022 · 0 comments
Closed

predict.lcModel() result can trigger error in transformPredict() #120

niekdt opened this issue Jun 30, 2022 · 0 comments
Assignees
@niekdt
Labels
bug Something isn't working

Comments

@niekdt
Copy link
Collaborator

niekdt commented Jun 30, 2022

As revealed in #109 (reply in thread), the use of lcModelKML can trigger an error condition flow in transformPredict().

#116 introduced a bug in transformPredict(). If the data contains a Cluster column but the predict method is not using the Cluster column information, transformPredict() is wrongly trying to use it for merging prediction data and new data.

Current fix: predict.lcModel will remove the Cluster column if it is not being used.
Alternative potential solution: a similar useCluster toggle for transformPredict()
@niekdt niekdt added the bug Something isn't working label Jun 30, 2022
@niekdt niekdt self-assigned this Jun 30, 2022
niekdt added a commit that referenced this issue Jun 30, 2022
@niekdt
Removed browser() statement and fixed bug in predict() for when clust…
52bc4f6 
…er column is present but not used (#120)
@niekdt niekdt closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niekdt niekdt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niekdt