Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env map to error page #46

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EriksonBahr
Copy link

@EriksonBahr EriksonBahr commented Aug 11, 2023

Description

Inject env vars to error page so custom (and enhanced error pages) can be created. So these envs can be accessed via .Env.MyEnv, the initial intent is to add arbitrary URLs that the user can be redirected to (instead of the default Redirect urls).

Motivation and Context

The default error page looks like a bootstrap develop page and we want to make it more like a philips one. See figma below

image

How Has This Been Tested?

Added a custom error page to our own docker image via

COPY ./static_pages/ ./static_pages

ENV OAUTH2_PROXY_CUSTOM_TEMPLATES_DIR=./static_pages

Then authenticated in our app, then press the back button in the browser and then refresh the page:

image

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@EriksonBahr EriksonBahr marked this pull request as draft February 1, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant