Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error API Manning equation #30

Closed
smultsch opened this issue Apr 26, 2018 · 2 comments
Closed

Error API Manning equation #30

smultsch opened this issue Apr 26, 2018 · 2 comments
Assignees
Labels
C++ Need to change C++ files (.h, .cpp) documentation
Milestone

Comments

@smultsch
Copy link

smultsch commented Apr 26, 2018

Hello,

seems like there is an error in the description of the Manning's equation (https://philippkraft.github.io/cmf/classcmf_1_1river_1_1_manning.html). I think the equation should look like this:

q_manning = (1/n_manning) * (A/P)(2/3) * (delta_z)(1/2)*A

Maybe split the calculation of the total flow (m3/sec) into the two calculation steps flow_velocity (m/s) and flow_rate (m³/sec):

flow_velocity = (1/n_manning) * (A/P)(2/3) * (delta_z)(1/2)
flow_rate = flow_velocity * A

Cheers,
Sebastian

check_manning.zip

@philippkraft philippkraft added documentation C++ Need to change C++ files (.h, .cpp) labels Apr 26, 2018
@philippkraft philippkraft added this to the 1.4 milestone Apr 26, 2018
@philippkraft philippkraft self-assigned this Apr 26, 2018
@philippkraft
Copy link
Owner

Need to check if the error is also in the calculation

@philippkraft
Copy link
Owner

Need to rebuilt docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Need to change C++ files (.h, .cpp) documentation
Projects
None yet
Development

No branches or pull requests

2 participants