fix: predictDraw should give same result as python #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philihp lots of things have changed since v5.1.1 btw, for instance, predict_draw no longer ranges between 0 and 1, but between 0 and 0.5 to make it obvious that the variance is taken into account. Weights is also implemented now for rate. I was going to make an issue on this repo, but might as well comment here now. |
|
Thanks! Yeah I was looking at the Python code and it looks like a lot has changed. |
|
I'm seeing that you have predict functions attached to the model. Do you anticipate they'll be different? |
|
No, that was done when I was considering adding other models. It actually does not make sense anymore. I will have to get around to changing it back to the way it was before, but for now it's easier to test things this way. |
philihp
force-pushed
the
predict-draw-parity
branch
from
02f5535 to
5cd160e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think maybe #611 didn't exactly get us there. This creates some tests pulled from #599 and from https://openskill.me, and the Javascript library should give the same result.