[Enhanced] Execute "javascript:" URLs by injecting them into the page itself. #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `chrome.tabs.update()` no longer supports `javascript:` URLs, here we inject them into the page itself. Replaces philc#3167. Replaces philc#3209. Fixes philc#3178.
gdh1995
force-pushed
the
inject-javascript-urls
branch
from
31747bb
to
3801e25
Compare
gdh1995
force-pushed
the
inject-javascript-urls
branch
from
3801e25
to
7288b6b
Compare
|
Great work @gdh1995. Thank you! |
|
Thanks guys! |
|
@philc I'm not seeing this release in Chrome (it thinks 1.64.6 is the latest). |
|
I see it now - thanks! And it's back to working as it once did; makes me very happy :) |
|
Thanks for the effort, now my engine "Search in current site" is working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhanced version of #3211, and adds
try decodeURItojavascriptURLs.Replaces and fixes #3211.
Replaces and fixes #3209.
Fixes #3178.
Fixes #3246 .