pass down sync void config to jsi module

Summary: Changelog: [Internal] actually pass down the config value -_- Reviewed By: christophpurrer Differential Revision: D51279435
philIip · Nov 13, 2023 · ffe9837 · ffe9837
1 parent ad0f064
commit ffe9837
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/...act-native/ReactAndroid/src/main/jni/react/turbomodule/ReactCommon/TurboModuleManager.cpp b/...act-native/ReactAndroid/src/main/jni/react/turbomodule/ReactCommon/TurboModuleManager.cpp
@@ -135,7 +135,8 @@ TurboModuleProviderFunctionType TurboModuleManager::createTurboModuleProvider(
           nativeMethodCallInvoker_ =
               std::weak_ptr<NativeMethodCallInvoker>(nativeMethodCallInvoker_),
           delegate_ = jni::make_weak(delegate_),
-          javaPart_ = jni::make_weak(javaPart_)](
+          javaPart_ = jni::make_weak(javaPart_),
+          enableSyncVoidMethods](
              const std::string& name) -> std::shared_ptr<TurboModule> {
     auto turboModuleCache = turboModuleCache_.lock();
     auto jsCallInvoker = jsCallInvoker_.lock();
@@ -197,7 +198,7 @@ TurboModuleProviderFunctionType TurboModuleManager::createTurboModuleProvider(
           .instance = moduleInstance,
           .jsInvoker = jsCallInvoker,
           .nativeMethodCallInvoker = nativeMethodCallInvoker,
-          .shouldVoidMethodsExecuteSync = false};
+          .shouldVoidMethodsExecuteSync = enableSyncVoidMethods};
 
       auto turboModule = delegate->cthis()->getTurboModule(name, params);
       turboModuleCache->insert({name, turboModule});
@@ -209,8 +210,8 @@ TurboModuleProviderFunctionType TurboModuleManager::createTurboModuleProvider(
   };
 }
 
-TurboModuleProviderFunctionType TurboModuleManager::createLegacyModuleProvider(
-    bool enableSyncVoidMethods) {
+TurboModuleProviderFunctionType
+TurboModuleManager::createLegacyModuleProvider() {
   return [legacyModuleCache_ = std::weak_ptr<ModuleCache>(legacyModuleCache_),
           jsCallInvoker_ = std::weak_ptr<CallInvoker>(jsCallInvoker_),
           nativeMethodCallInvoker_ =
@@ -322,7 +323,7 @@ void TurboModuleManager::installJSIBindings(
     TurboModuleBinding::install(
         runtime,
         createTurboModuleProvider(enableSyncVoidMethods),
-        createLegacyModuleProvider(enableSyncVoidMethods));
+        createLegacyModuleProvider());
   });
 }
 

diff --git a/...react-native/ReactAndroid/src/main/jni/react/turbomodule/ReactCommon/TurboModuleManager.h b/...react-native/ReactAndroid/src/main/jni/react/turbomodule/ReactCommon/TurboModuleManager.h
@@ -68,8 +68,7 @@ class TurboModuleManager : public jni::HybridClass<TurboModuleManager> {
 
   TurboModuleProviderFunctionType createTurboModuleProvider(
       bool enableSyncVoidMethods);
-  TurboModuleProviderFunctionType createLegacyModuleProvider(
-      bool enableSyncVoidMethods);
+  TurboModuleProviderFunctionType createLegacyModuleProvider();
 };
 
 } // namespace facebook::react