Skip to content

Commit

Permalink
Move test_windows under test_JS (facebook#41455)
Browse files Browse the repository at this point in the history
Summary:
CircleCI was broken since Friday because a change broke JS tests on Windows only.
The test_windows job didn't run on those changes because they were JS changes only, therefore won't affect the build of React Native on Windows.

The `test_windows` was listed among the various `test_android` jobs, but it is not actually building React Native android on windows machines.
Instead, the test_windows jobs is actually only running JS tests on a windows machines. Therefore, it makes more sense to have this test under the test_js group.

bypass-github-export-checks

## Changelog:
[Internal] - Move the test_windows job under the testJS configuration

Pull Request resolved: facebook#41455

Test Plan:
CircleCI is green.
test_windows run together with the JS tests

Reviewed By: mdvacca

Differential Revision: D51258120

Pulled By: cipolleschi

fbshipit-source-id: a523c48f697b64620433ec9672f13baa308d75a8
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Nov 13, 2023
1 parent a226b90 commit 6962b5f
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion .circleci/configurations/test_workflows/testAll.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,4 +115,3 @@
matrix:
parameters:
jsengine: ["Hermes", "JSC"]
- test_windows
1 change: 0 additions & 1 deletion .circleci/configurations/test_workflows/testAndroid.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,3 @@
architecture: ["NewArch", "OldArch"]
jsengine: ["Hermes", "JSC"]
flavor: ["Debug", "Release"]
- test_windows
1 change: 1 addition & 0 deletions .circleci/configurations/test_workflows/testJS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@
- test_js:
name: test_js_prev_lts
executor: nodeprevlts
- test_windows

0 comments on commit 6962b5f

Please sign in to comment.