Handle non-printable characters in vga buffer module #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -203,12 +203,23 @@ To print whole strings, we can convert them to bytes and print them one-by-one: | |||
| impl Writer { | |||
| pub fn write_string(&mut self, s: &str) { | |||
| for byte in s.bytes() { | |||
| self.write_byte(byte) | |||
| match byte { | |||
There was a problem hiding this comment.
Instead of a match we could use an if condition:
if byte.is_ascii() {
self.write_byte(byte);
} else {
self.write_byte(0xfe);
}
There was a problem hiding this comment.
That also includes non-printable ASCII bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @fpsiorz in #405 (comment).
I decided to modify
write_stringinstead ofwrite_byte, because it allows us to still print the additional bytes of codepage 437 viawrite_byte(e.g. a■for non-ASCII characters).A better solution would be to translate UTF-8 to codepage 437 where possible, but I think that would be too much code for the blog. Maybe we could do it via an external crate.