Update vga-text-buffer failed link for normal reads and write. #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the hyperlink for 'supports normal reads and writes' in post 3 was redirecting to a page not found, as I guess Stanford has remove that link. So I have added the correct link, which redirects to Stanford's Secure Systems Group, where they have the deails about CS140 course and relevant pintos docs.
phil-opp
reviewed
Feb 8, 2024
| @@ -60,7 +60,7 @@ The VGA text buffer is accessible via [memory-mapped I/O] to the address `0xb800 | |||
|
|
|||
| Note that memory-mapped hardware might not support all normal RAM operations. For example, a device could only support byte-wise reads and return junk when a `u64` is read. Fortunately, the text buffer [supports normal reads and writes], so we don't have to treat it in a special way. | |||
|
|
|||
| [supports normal reads and writes]: https://web.stanford.edu/class/cs140/projects/pintos/specs/freevga/vga/vgamem.htm#manip | |||
| [supports normal reads and writes]: https://www.scs.stanford.edu/21wi-cs140/pintos/specs/freevga/vga/vga.htm | |||
There was a problem hiding this comment.
The corresponding page under the new URL would be https://www.scs.stanford.edu/21wi-cs140/pintos/specs/freevga/vga/vgamem.htm#manip . But it seems like the "old" URL is also working (again?).
There was a problem hiding this comment.
Thanks for the correction.Yeah! previously added link is also working now. Will close my PR then.
|
The change is no more applicable as the corrected link is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the hyperlink for 'supports normal reads and writes' in post 3 was redirecting to a page not found, as I guess Stanford has remove that link. So I have added the correct link, which redirects to Stanford's Secure Systems Group, where they have details about CS140 course and relevant pintos docs.