Skip to content

Commit

Permalink
doc: VP solver is validated with OpenMP
Browse files Browse the repository at this point in the history
When the implicit VP solver was added in f7fd063 (dynamics: add implicit
VP solver (CICE-Consortium#491), 2020-09-22), it had not yet been tested with OpenMP
enabled.

The OpenMP implementation was carefully reviewed and then fixed in
d1e972a (Update OMP (CICE-Consortium#680), 2022-02-18), which lead to all runs of the
'decomp' suite completing and all restart tests passing. The 'bfbcomp'
tests are still failing, but this is due to the code not using the CICE
global sum implementation correctly, which will be fixed in the next
commits.

Update the documentation accordingly.
  • Loading branch information
phil-blain committed Oct 17, 2022
1 parent 5263344 commit edd1876
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions doc/source/science_guide/sg_dynamics.rst
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ dynamics into CICE is described in detail in
The VP solver implementation mostly follows :cite:`Lemieux08`, with
FGMRES :cite:`Saad93` as the linear solver and GMRES as the preconditioner.
Note that the VP solver has not yet been tested on the ``tx1`` grid or with
threading enabled.
Note that the VP solver has not yet been tested on the ``tx1`` grid.

The EVP, rEVP, EAP and VP approaches are all available with the B grid. However, at the moment, only the EVP and rEVP schemes are possible with the C grid.

Expand Down

0 comments on commit edd1876

Please sign in to comment.