Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace if temperatures with if temperature is not None #989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tesla2000
Copy link

Fixing #988 for OpenAiChat.

@jacobweiss2305 jacobweiss2305 self-requested a review May 31, 2024 16:40
@jacobweiss2305
Copy link
Contributor

>>> "yes" if 0 else "no"
'no'

This simple test proves we should check for None instead of None or 0.

@Tesla2000
Copy link
Author

I see you approved. Great, however I am unable to merge. Are more approval required?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants