Skip to content

Commit

Permalink
opt out of todo-should-have-issue in package.json of the repo, phetsi…
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Jan 16, 2023
1 parent 0cc31aa commit a93de0c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion js/wave-on-a-string/model/WOASModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class WOASModel extends PhetioObject {
units: 'cm',
phetioValueType: NumberIO
} );
// TODO: how to support range on dynamic properties?
// TODO: how to support range on dynamic properties? https://github.com/phetsims/wave-on-a-string/issues/147
this.waveStartPositionProperty.range = new Range( -1.3, 1.3 );

// @private {Property.<number>}
Expand Down
2 changes: 1 addition & 1 deletion js/wave-on-a-string/view/BottomControlPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class BottomControlPanel extends Panel {
map: value => value * 100,
inverseMap: value => value / 100
} );
// TODO: how to support range on dynamic properties?
// TODO: how to support range on dynamic properties? https://github.com/phetsims/wave-on-a-string/issues/147
tensionProperty.range = new Range( model.tensionProperty.range.min * 100, model.tensionProperty.range.max * 100 );

const tensionControl = new WOASNumberControl( tensionString, tensionProperty, {
Expand Down

0 comments on commit a93de0c

Please sign in to comment.