Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect voice used in iOS 15.4 + Safari #74

Closed
jessegreenberg opened this issue Apr 4, 2022 · 18 comments
Closed

Incorrect voice used in iOS 15.4 + Safari #74

jessegreenberg opened this issue Apr 4, 2022 · 18 comments

Comments

@jessegreenberg
Copy link
Contributor

I am seeing this issue again in phetsims/qa#791 with iOS 15.4 + Safari.

Ignore my big hand in this video!

voices.mov

Originally posted by @Nancy-Salpepi in phetsims/friction#268 (comment)

@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Apr 4, 2022

The original issue in phetsims/friction#268 (comment) was about the wrong voice after selecting an item in the voice ComboBox. But what is shown in @Nancy-Salpepi's video here is even more broken, it looks like "Fred" always sounds like "Samantha".

@jessegreenberg
Copy link
Contributor Author

I confirmed this on my iPad Air 2, I have Fred and Samantha and both Voices sound like Samantha.

@jessegreenberg jessegreenberg self-assigned this Apr 4, 2022
@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Apr 4, 2022

I tried to re-install Fred to see if I could repair it but apparently you cannot delete Voices once you install them...https://discussions.apple.com/thread/252817481

I will tether my iPad to my Mac and inspect the voice every time we request speech to see if it looks like "Fred". Ill also try installing another english voice and seeing if it sounds correct.

@zepumph
Copy link
Member

zepumph commented Aug 31, 2022

@jessegreenberg could you give a status update on this. @emily-phet, is this blocking frictions release?

@Nancy-Salpepi
Copy link

Weird that we were looking at this issue at the same time @zepumph.
@jessegreenberg I am seeing this while testing ratio and proportion (phetsims/qa#831)
with iOS 15.6.1 AND macOS 12.5.1 + safari. Also seen with published versions of JT and GFL:B.

@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Aug 31, 2022

I have not investigated this yet but should! There may be something in the stack trace or maybe some field on the voice that indicates why it sounds incorrect. But it is unclear and we may not be able to prune the broken voice.

@emily-phet
Copy link

Let's couple this investigation with that for #75. If the root of the issue for these is something relatively straightforward on our end, let's fix. If it's a hard fix, or unclear if it's something on our end, let's defer.

@zepumph
Copy link
Member

zepumph commented Oct 12, 2022

Adding myself for investigation.

@zepumph
Copy link
Member

zepumph commented Oct 14, 2022

It is incredibly easy to reproduce this problem. When I downloaded more voices, no matter what, I only had access to the voice that was initially available. @jessegreenberg and I found that this is a known bug with iOS:

Treat this as the caniuse blog: https://weboutloud.io/bulletin/speech_synthesis_in_safari/
https://stackoverflow.com/a/61347785/3408502
https://talkrapp.com/speechSynthesis.html (paragraph above the list of iOS voices)
https://developer.apple.com/forums/thread/106517

Basically it isn't currently supported to change any the voice from the default.

Thus we are in workaround mode.

We tried just only displaying the default voice, so that the combo box would just have a single voice in the list (the one that was already on and wasn't changeable), but that didn't work at all! Even though I had downloaded another.

zepumph added a commit to phetsims/joist that referenced this issue Oct 14, 2022
@zepumph zepumph assigned KatieWoe and unassigned jessegreenberg and zepumph Oct 14, 2022
@zepumph
Copy link
Member

zepumph commented Oct 14, 2022

QA, please note that there is no longer a voice selector in iOS. Feel free to close.

@Nancy-Salpepi
Copy link

noted in QA book. Closing

@zepumph
Copy link
Member

zepumph commented Oct 14, 2022

While investigating #75, @chrisklus and I found that we could reproduce this with MacOS version 12.6 Safari 15.6.1 (latest version).

Furthermore, Chris always had a default of "Alex" (it was first in the list). We found this even when when we changed the system voice to Samantha, cleared caches and refreshed. We also found this even when we removed the line setting any voice to utterances to the system. We aren't sure about how to control this, or if it is even possible.

Are we going to need to hide the voice control for all safari?!?!?!

@jessegreenberg
Copy link
Contributor Author

I just tested this in Safari 15.4 tech preview and saw this happening there. Then I tested in default safari (15.2 on my machine) and the available voices worked correctly.

@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Oct 14, 2022

According to https://weboutloud.io/bulletin/speech_synthesis_in_safari/ the inability to change voices is not specific to iOS but is happening at least as early as version 15.4 :(

I am OK removing the control entirely in Safari.

@zepumph
Copy link
Member

zepumph commented Oct 14, 2022

15.4 is pretty recent. This seems like a regression that is more likely to be fixed than many other bugs we encounter. Furthermore, the bug doesn't effect usability, but is instead just confusing. What if instead we just kept the combo box in for safari, hoping that safari will get's it together in a soon-to-be-released version?

@emily-phet
Copy link

Here's my 2 cents...I agree here with @zepumph - Let's just leave the voice options as is across all contexts, document somewhere that this issue exists (we can even include a brief mention of this in supporting materials for teachers), and cross our fingers that Safari improves soon.

@zepumph
Copy link
Member

zepumph commented Oct 19, 2022

@emily-phet and I spoke about this today and we are in agreement about leaving the buggy selector in place with hopes that Apple fixes the bug.

@zepumph
Copy link
Member

zepumph commented Oct 19, 2022

Reverted above. I added a note about how it is currently broken. Closing

@zepumph zepumph closed this as completed Oct 19, 2022
zepumph added a commit to phetsims/joist that referenced this issue Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants