Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UtteranceQueue.cancelUtterance should remove an Utterance from the queue #68

Closed
jessegreenberg opened this issue Mar 13, 2022 · 1 comment
Closed

UtteranceQueue.cancelUtterance should remove an Utterance from the queue #68

jessegreenberg opened this issue Mar 13, 2022 · 1 comment
Assignees
@jessegreenberg

Comments

@jessegreenberg
Copy link
Contributor

Currently it just forwards the cancel to the announcer but I think the correct behavior would be to also remove the provided utterance form the queue if it is provided. This is causing phetsims/joist#782 and if the utterance were removed from the queue in cancelUtterance we wouldn't have that issue.
@jessegreenberg jessegreenberg self-assigned this Mar 13, 2022
jessegreenberg added a commit that referenced this issue Mar 13, 2022
@jessegreenberg
remove utterances from the queue in cancelUtterance, see #68
b2b4251
jessegreenberg added a commit that referenced this issue Mar 13, 2022
@jessegreenberg
update documentation for cancelUtterance, see #68
428ef87
@jessegreenberg jessegreenberg mentioned this issue Mar 13, 2022
Closed
@jessegreenberg
Copy link
Contributor Author

Done in the above commit, seems to be working and unit tests still pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg