-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check on repository licenses #875
Comments
@kathy-phet replied:
|
Based on @kathy-phet's remarks, it seems we should license our repositories like so:
Aqua and phetmarks depend on simulations so that would suggest they should be GPL, but they seem like they should be MIT to me. (Not sure if we would want to require 3rd parties to release changes to that as GPL like they would for simulations.) . Or perhaps the rule is more like "anything that is a sim or like a sim is GPL and everything else is MIT". I recommend that a developer looks through our repos and identifies which licenses should be changed and make the changes, or identify if there are any other repos which don't fit into the categories above (for discussion and decision). @ariel-phet if you agree, can you please prioritize/schedule/delegate? |
@samreid can you give me a WAG on how much time this would take? |
I guess an hour or so would be sufficient to scan through everything and update it. |
@samreid an hour seems reasonable to do. I would say when you feel like a somewhat more "brainless" task, just take this on at your convenience. Marking medium since it will be quick. Let's say sometime in the next month. |
I got a list of all repos here: |
I pasted those into a file then ran this; var allPages = page1.concat( page2 );
var sorted = _.sortBy( allPages, 'name' )
// var names = allPages.map(function(a){return a.name;}).sort();
// console.log(allPages.length);
// for ( var i = 0; i < names.length; i++ ) {
// console.log( names[ i ]);
// }
// console.log( allPages.length );
// console.log(sorted.map(function(s){return s.clone_url;}));
sorted.forEach(function(s){
console.log('git clone '+s.clone_url);
}); Then I cloned 127 repos. |
Using this code: sorted.forEach( function( s ) {
var repo = '../licenses/' + s.name + '/LICENSE';
var x = 'none';
try {
x = fs.readFileSync( repo,'utf8' );
}
catch( m ) {}
console.log( s.name + ': ' + x.substring(0,x.indexOf('\n')) );
} ); I generated a list of all our licenses, coming in next comment. |
Here are all the licenses: I'll put an X by the ones that look sketchy:
|
I marked some potential issues, but I also noticed that some are MIT (MIT) and some are MIT. We should unify all of these, and make sure GPL are all same version too. |
|
From phetsims/circuit-construction-kit-common#383
6/29/17 dev meeting notes:
• circuit-construction-kit-common, inverse-square-law-common and shred should all be GPL
• why can't everything be MIT?
• if everything can't be MIT, why not make all PhET-specific common code GPL, and use MIT only for common code (and dependencies) that is useful outside of PhET?
The text was updated successfully, but these errors were encountered: