-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Voicing and InteractiveHighlighting to AccordionBox #743
Comments
InteractiveHighlighting added for the title bars directly below. I'm a bit curious about this implementation. A few thoughts:
|
|
The voicing side of things went very smoothly here. I'm pretty much just passing everything through to the button and it just works! I love it when that happens, and it is a testament to how nice when the voicing/description/alt-input designs can all align. I will want to discuss some of the above topics with @jessegreenberg on Friday, and after I will reach out to @terracoda for a review, but first I want her to look at the sim-specific implementation. |
That said, there is code in the ResetAllButton to disable voicing while resetting, thus I open the accordionBox and press reset and don't hear anything but "Reset All, Everything reset." |
In https://docs.google.com/document/d/1offJbONUg8y5Aa9kHewC9iTDtNISzna4giGt7WrpXCk/edit?disco=AAAAVatjjs0&usp=comment_email_discussion&usp_dm=true&ts=62222b0b @terracoda mentioned that we don't need to have the object response upon focus, so we can use the default focus listener. |
Thinks are going well in Ratio and Proportion. Ready to close. |
From phetsims/ratio-and-proportion#381, design in https://docs.google.com/document/d/1offJbONUg8y5Aa9kHewC9iTDtNISzna4giGt7WrpXCk/edit#heading=h.nvlwmm9fjx2v
The text was updated successfully, but these errors were encountered: