Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Voicing and InteractiveHighlighting to AccordionBox #743

Closed
zepumph opened this issue Mar 2, 2022 · 6 comments
Closed

Add Voicing and InteractiveHighlighting to AccordionBox #743

zepumph opened this issue Mar 2, 2022 · 6 comments

Comments

@zepumph
Copy link
Member

zepumph commented Mar 2, 2022

From phetsims/ratio-and-proportion#381, design in https://docs.google.com/document/d/1offJbONUg8y5Aa9kHewC9iTDtNISzna4giGt7WrpXCk/edit#heading=h.nvlwmm9fjx2v

@zepumph
Copy link
Member Author

zepumph commented Mar 2, 2022

InteractiveHighlighting added for the title bars directly below. I'm a bit curious about this implementation. A few thoughts:

  • It looks like the only way to hide an interactiveHighlight on a Node is to set interactiveHighlight:null and also focusHighlight: 'invisible'. Seems weird to me!
  • I think we could have the interactive highlight around the whole expanded box if we want to, but I'll want to ask a designer.

@zepumph
Copy link
Member Author

zepumph commented Mar 2, 2022

  • There is currently no way to listen to the interaction regarding expand/collapse, only the Property (which presumably means ignoring on reset/iO state etc).

@zepumph
Copy link
Member Author

zepumph commented Mar 2, 2022

The voicing side of things went very smoothly here. I'm pretty much just passing everything through to the button and it just works! I love it when that happens, and it is a testament to how nice when the voicing/description/alt-input designs can all align. I will want to discuss some of the above topics with @jessegreenberg on Friday, and after I will reach out to @terracoda for a review, but first I want her to look at the sim-specific implementation.

zepumph added a commit to phetsims/scenery that referenced this issue Mar 2, 2022
@zepumph
Copy link
Member Author

zepumph commented Mar 3, 2022

There is currently no way to listen to the interaction regarding expand/collapse, only the Property (which presumably means ignoring on reset/iO state etc).

That said, there is code in the ResetAllButton to disable voicing while resetting, thus I open the accordionBox and press reset and don't hear anything but "Reset All, Everything reset."

zepumph added a commit that referenced this issue Mar 4, 2022
@zepumph
Copy link
Member Author

zepumph commented Mar 4, 2022

In https://docs.google.com/document/d/1offJbONUg8y5Aa9kHewC9iTDtNISzna4giGt7WrpXCk/edit?disco=AAAAVatjjs0&usp=comment_email_discussion&usp_dm=true&ts=62222b0b @terracoda mentioned that we don't need to have the object response upon focus, so we can use the default focus listener.

@zepumph
Copy link
Member Author

zepumph commented May 12, 2022

Thinks are going well in Ratio and Proportion. Ready to close.

@zepumph zepumph closed this as completed May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant