You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding a TODO to a usage of isSettingPhetioStateProperty, from working on phetsims/tandem#314.
It is possible that you could have awkward order dependencies by listening to the Property, since that is the event for "we are done setting state". For example the soundManager uses this to re-enabled audio. Adding a TODO to listen to the stateSetEmitter instead makes sense here, but I don't know the logic well enough to be able to test things. This isn't high priority or anything, just a minor code smell.
Adding a TODO to a usage of
isSettingPhetioStateProperty
, from working on phetsims/tandem#314.It is possible that you could have awkward order dependencies by listening to the Property, since that is the event for "we are done setting state". For example the soundManager uses this to re-enabled audio. Adding a TODO to listen to the stateSetEmitter instead makes sense here, but I don't know the logic well enough to be able to test things. This isn't high priority or anything, just a minor code smell.
https://github.com/phetsims/center-and-variability/blob/8dc7c64447c6b0a67999ca9fb120728f85f028d3/js/common/model/CAVSoccerSceneModel.ts#L60-L64
soccer-common/js/model/SoccerSceneModel.ts
Lines 281 to 285 in abc37e5
The text was updated successfully, but these errors were encountered: