Skip to content

Commit

Permalink
add comments with numbers that correspond to #13 (comment)
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Mar 12, 2024
1 parent 6abdbf3 commit 2d694f3
Show file tree
Hide file tree
Showing 2 changed files with 69 additions and 0 deletions.
32 changes: 32 additions & 0 deletions js/view/KickerPortrayalAfrica.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,56 +53,81 @@ const KickerPortrayalAfrica = new KickerPortrayal(

// Unnumbered Kickers
[
// 01: see https://github.com/phetsims/soccer-common/issues/13#issuecomment-1992492081
{
standing: africaKicker01Standing_svg,
poisedToKick: africaKicker01PoisedToKick_svg,
kicking: africaKicker01Kicking_svg
},

// 02
{
standing: africaKicker02Standing_svg,
poisedToKick: africaKicker02PoisedToKick_svg,
kicking: africaKicker02Kicking_svg
},

// 03
{
standing: africaKicker03Standing_svg,
poisedToKick: africaKicker03PoisedToKick_svg,
kicking: africaKicker03Kicking_svg
},

// 04
{
standing: africaKicker04Standing_svg,
poisedToKick: africaKicker04PoisedToKick_svg,
kicking: africaKicker04Kicking_svg
},

// 05
KickerPortrayalUSA.unnumberedKickerImages[ 8 - 1 ],

// 06
KickerPortrayalUSA.unnumberedKickerImages[ 14 - 1 ],

// 07
{
standing: africaKicker07Standing_svg,
poisedToKick: africaKicker07PoisedToKick_svg,
kicking: africaKicker07Kicking_svg
},

// 08
KickerPortrayalUSA.unnumberedKickerImages[ 12 - 1 ],

// 09
KickerPortrayalUSA.unnumberedKickerImages[ 10 - 1 ],

// 10
KickerPortrayalUSA.unnumberedKickerImages[ 2 - 1 ],

// 11
{
standing: africaKicker11Standing_svg,
poisedToKick: africaKicker11PoisedToKick_svg,
kicking: africaKicker11Kicking_svg
},

// 12
KickerPortrayalUSA.unnumberedKickerImages[ 4 - 1 ],

// 13
{
standing: africaKicker13Standing_svg,
poisedToKick: africaKicker13PoisedToKick_svg,
kicking: africaKicker13Kicking_svg
},

// 14
{
standing: africaKicker14Standing_svg,
poisedToKick: africaKicker14PoisedToKick_svg,
kicking: africaKicker14Kicking_svg
},

// 15
{
standing: africaKicker15Standing_svg,
poisedToKick: africaKicker15PoisedToKick_svg,
Expand All @@ -112,21 +137,28 @@ const KickerPortrayalAfrica = new KickerPortrayal(

// Numbered Kickers
[
// 1
{
standing: africaVariabilityKicker01Standing_svg,
poisedToKick: africaVariabilityKicker01PoisedToKick_svg,
kicking: africaVariabilityKicker01Kicking_svg
},

// 2
{
standing: africaVariabilityKicker02Standing_svg,
poisedToKick: africaVariabilityKicker02PoisedToKick_svg,
kicking: africaVariabilityKicker02Kicking_svg
},

// 3
{
standing: africaVariabilityKicker03Standing_svg,
poisedToKick: africaVariabilityKicker03PoisedToKick_svg,
kicking: africaVariabilityKicker03Kicking_svg
},

// 4
{
standing: africaVariabilityKicker04Standing_svg,
poisedToKick: africaVariabilityKicker04PoisedToKick_svg,
Expand Down
37 changes: 37 additions & 0 deletions js/view/KickerPortrayalAfricaModest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,60 +39,97 @@ const KickerPortrayalAfricaModest = new KickerPortrayal(

// Unnumbered Kickers
[

// 01: see https://github.com/phetsims/soccer-common/issues/13#issuecomment-1992492081
{
standing: africaModestKicker01Standing_svg,
poisedToKick: africaModestKicker01PoisedToKick_svg,
kicking: africaModestKicker01Kicking_svg
},

// 02
{
standing: africaModestKicker02Standing_svg,
poisedToKick: africaModestKicker02PoisedToKick_svg,
kicking: africaModestKicker02Kicking_svg
},

// 03
{
standing: africaModestKicker03Standing_svg,
poisedToKick: africaModestKicker03PoisedToKick_svg,
kicking: africaModestKicker03Kicking_svg
},

// 04
KickerPortrayalAfrica.unnumberedKickerImages[ 7 - 1 ],

// 05
{
standing: africaModestKicker05Standing_svg,
poisedToKick: africaModestKicker05PoisedToKick_svg,
kicking: africaModestKicker05Kicking_svg
},

// 06
KickerPortrayalUSA.unnumberedKickerImages[ 8 - 1 ],

// 07
{
standing: africaModestKicker07Standing_svg,
poisedToKick: africaModestKicker07PoisedToKick_svg,
kicking: africaModestKicker07Kicking_svg
},

// 08
KickerPortrayalAfrica.unnumberedKickerImages[ 14 - 1 ],

// 09
KickerPortrayalAfrica.unnumberedKickerImages[ 3 - 1 ],

// 10
KickerPortrayalUSA.unnumberedKickerImages[ 2 - 1 ],

// 11
{
standing: africaModestKicker11Standing_svg,
poisedToKick: africaModestKicker11PoisedToKick_svg,
kicking: africaModestKicker11Kicking_svg
},

// 12
KickerPortrayalAfrica.unnumberedKickerImages[ 1 - 1 ],

// 13
{
standing: africaModestKicker13Standing_svg,
poisedToKick: africaModestKicker13PoisedToKick_svg,
kicking: africaModestKicker13Kicking_svg
},

// 14
KickerPortrayalAfrica.unnumberedKickerImages[ 4 - 1 ],

// 15
KickerPortrayalAfrica.unnumberedKickerImages[ 15 - 1 ]
],

// Numbered Kickers
[
// 1
KickerPortrayalAfrica.numberedKickerImages[ 1 - 1 ],

// 2
{
standing: africaModestVariabilityKicker02Standing_svg,
poisedToKick: africaModestVariabilityKicker02PoisedToKick_svg,
kicking: africaModestVariabilityKicker02Kicking_svg
},

// 3
KickerPortrayalAfrica.numberedKickerImages[ 3 - 1 ],

// 4
KickerPortrayalAfrica.numberedKickerImages[ 4 - 1 ]
]
);
Expand Down

0 comments on commit 2d694f3

Please sign in to comment.