-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address problems with KeyboardDragListener options #1635
Labels
Comments
jessegreenberg
added a commit
to phetsims/area-model-common
that referenced
this issue
Jun 3, 2024
jessegreenberg
added a commit
to phetsims/density-buoyancy-common
that referenced
this issue
Jun 3, 2024
jessegreenberg
added a commit
to phetsims/faradays-law
that referenced
this issue
Jun 3, 2024
jessegreenberg
added a commit
to phetsims/gas-properties
that referenced
this issue
Jun 3, 2024
jessegreenberg
added a commit
to phetsims/quadrilateral
that referenced
this issue
Jun 3, 2024
jessegreenberg
added a commit
to phetsims/geometric-optics
that referenced
this issue
Jun 3, 2024
jessegreenberg
added a commit
to phetsims/scenery-phet
that referenced
this issue
Jun 3, 2024
jessegreenberg
added a commit
to phetsims/ph-scale
that referenced
this issue
Jun 3, 2024
jessegreenberg
added a commit
that referenced
this issue
Jun 3, 2024
The fields and options are better aligned. I also made it more clear how deltas are applied in the drag action and fixed how translateNode works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A couple of problems identified while working on #1614
modelDelta
(DragListener) is calledvectorDelta
in KeyboardDragListener.translateNode
.positionProperty
and usedrag
callback directly instead.Lets clean these things up and make the API for DragListener and KeyboardDragListener more similar. This will make it easier to use RichDragListener.
The text was updated successfully, but these errors were encountered: